[Feature-2582][Connector] Add Hashes && Lists in Redis Sink #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
added
connectors-v2
connectors-v1
hailin0
reviewed
Sep 1, 2022
I will complete it. |
Testcase reference #2429 |
I tried it, please review again. |
hailin0
reviewed
Sep 2, 2022
|
|
||
| @Test | ||
| public void testFakeSourceToRedisSink() throws IOException, InterruptedException { | ||
| Container.ExecResult execResult = executeSeaTunnelSparkJob("/jdbc/fakesource_to_redis.conf"); |
There was a problem hiding this comment.
|
|
||
| sink { | ||
| redis { | ||
| host = "localhost" |
There was a problem hiding this comment.
Connect to redis-server you started in testcase?
There was a problem hiding this comment.
Suggested change
| host = "localhost" | |
| host = "spark_e2e_redis" |
wuchunfu
reviewed
Sep 3, 2022
Hisoka-X
requested review from
hailin0 and
wuchunfu
and removed request for
hailin0
hailin0
reviewed
Sep 29, 2022
|
|
||
| sink { | ||
| redis { | ||
| host = "localhost" |
There was a problem hiding this comment.
Suggested change
| host = "localhost" | |
| host = "spark_e2e_redis" |
|
Since this pr has not been updated for too long, I will close it. If necessary, please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #2582